Fix for wound overlays. #5787
Merged
Fix for wound overlays. #5787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harryob
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Yet another disastrous consequence of that "research warcrimes" PR. For whatever reason, it removed a line that actually was doing something important. If we have been processing the limb (otherwise
need_process()should not be called at all) and after going through all the checks decided to cease processing it (which only happens when all damage is gone), we do need to update wounds one final time first to remove all the overlays from wounds/bandages that have healed but have not been removed by limb's not-every-tick update in regularprocess().Explain why it's good for the game
Fixes #4764.
Changelog
🆑
fix: Fully healed limbs should now properly remove the overlays for their wounds and bandages.
/:cl: